http-keepalive must be set as int from ini

[kbutz]

I'm not sure if this is a bug or if the documentation just needs to be a little more clear here.

While it is noted in the uWSGI config options that the parser for http-keepalive is uwsgi_opt_true, it isn't immediately obvious or clear. Making it worse, there are many examples floating around out there of people suggesting adding http-keepalve=true to their uwsgi.ini config files when the correct usage from

If this isn't a bug where http-keepalive=true should correctly enable keep-alives, I propose updating the Native HTTP documentation w/ an example.

Existing documentation: https://github.com/unbit/uwsgi-docs/blob/master/HTTP.rst

Here is the my .ini config for reference. After a lot of trouble shooting and digging through the uWSGI source, the only change I needed to make for keep-alives to be respected was to change http-keepalive=true to http-keepalive=1.

[uwsgi]

;show-config=true

; don't allow unrecognized options in this file
strict=true

; Set up uwsgi http router on the specified address with http and tcp keepalives enabled
http=0.0.0.0:8080
http-keepalive=1
add-header=Connection: Keep-Alive
http-timeout=90
http-connect-timeout=5
;Enable TCP keepalive
so-keepalive=true
; Set socket send timeout in seconds for SO_SNDTIMEO
so-send-timeout=7200

; Exit if the app isn't found/can't be loaded
need-app=true
manage-script-name=true
mount=/myapp=myapp:app

; Enable a single thread with a top level master process
master=true
enable-threads=true
threads=1
processes=1
; Don't run as root, set uid to run as
uid=12345

; Graceful shutdown on sigterm
hook-master-start=unix_signal:15 gracefully_kill_them_all

; Log memory statistics
memory-report=true

[kbutz]

If anyone knows if this is expected behavior or not, I would be happy to make the relevant changes.

If it is expected, I can update the documentation to make it more clear for the next person who wants to enable keep-alives from a wsgi.ini.

If it is unexpected, I can dust off my C skills and work on changing the config setting to a bool.

Thanks!

[xrmx]

Code suggests it should be a positive integer, so an hint about the type (seconds) would be nice to be added in help text in plugins/http/http.c.

[kbutz]

Thanks for the info! I'll get a PR together soon w/ added documentation here, and an .ini example in the uwsgi-docs repo.

From what I recall during my initial debugging, the value of http-keepalive is used as a bool, and not for any other configuration, like timeout in seconds, or seconds to keep an unused connection pooled. Most documentation shows the keepalives being set with a simple bool flag --http-keepalive

I'll take another look, and add any relevant documentation to the PR.

[kbutz]

Also related to: #1637

[kbutz]

Closing this issue since #2032 got merged