Design a better deploy system #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngle staging deploy script for now. Ran into trouble if GitHub Actions tried to deploy both at the same time. Will eventually have a better separated deploy scheme. In the api package.json scripts don't always run prettier and eslint before a build, just get rid of the old build directory.
jmg1138
added
🚀 Enhancement
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
===================================================
- Coverage 23.00147% 22.85575% -0.14573%
===================================================
Files 76 77 +1
Lines 2039 2052 +13
Branches 381 381
===================================================
Hits 469 469
- Misses 1444 1457 +13
Partials 126 126
Continue to review full report at Codecov.
|
…ange [explained here](https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis) so I made those required changes in the index.tsx file. Also added a little fun graffiti to the front-end that shows up in the browser console. Also slightly modified the graffiti in the back-end package.
…www.npmjs.com/package/react-helmet-async), due to [this issue](nfl/react-helmet#548). The async library requires a <HelmetProvider> encapsulation element, so I added that where I was already using the <Helmet> element.
…lly doing. Only difference now is that I don't stop the api process until later. Begins with stashing any local changes on the staging server (like the package-lock.json that is probably different) before doing the pull. Then the npm install. If all that has worked so far, then stop the api to create a fresh build before restarting it. After that, build the react web app too. Both would then be "deployed" to this alpha/hobby/staging server.
…ed the web package import paths to use relative local paths instead of based on the tsconfig root directory. I've been trying to find a nicer cleaner way to handle import paths in this project, but so far everything I try breaks something else that isn't simple to workaround. The relative paths might not be pretty, but they work, so for now I'm back to using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently just an alpha project, so it only deploys to a testing/staging environment. Even so, the current deploy steps are not good. Design a better deployment script from GitHub Actions.