Plugin 2024 Q1 maintenance update (115 commits) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See link from Feb 2021: https://blog.gradle.org/jcenter-shutdown
PR#28 Issue#27 overlaps this commit. Remove: com.sun.xml.bind:jaxb-xjc:3.0.0-M4 com.sun.xml.bind:jaxb-impl:3.0.0-M4 Replace with: com.sun.xml.bind:jaxb-xjc:3.0.2 com.sun.xml.bind:jaxb-core:3.0.2 com.sun.xml.bind:jaxb-impl:3.0.2 jakarta.xml.bind:jakarta.xml.bind-api:3.0.1
Issue#31 overlaps this commit.
com.sun.xml.bind:jaxb-xjc:2.4.0-b180830.0438 com.sun.xml.bind:jaxb-core:2.3.0.1 // there is no 2.4 version com.sun.xml.bind:jaxb-impl:2.4.0-b180830.0438 javax.xml.bind:jaxb-api:2.4.0-b180830.0359
Remove: com.sun.xml.bind:jaxb-xjc:2.3.3 Replace with: com.sun.xml.bind:jaxb-xjc:2.3.8 com.sun.xml.bind:jaxb-core:2.3.0.1 com.sun.xml.bind:jaxb-impl:2.3.8 javax.xml.bind:jaxb-api:2.3.1
Removed: javax.xml.bind:jaxb-api:2.2.11 Replaced with: javax.xml.bind:jaxb-api:2.2.12
Using: com.sun.xml.bind:jaxb-xjc:4.0.2 com.sun.xml.bind:jaxb-core:4.0.2 com.sun.xml.bind:jaxb-impl:4.0.2 jakarta.xml.bind:jakarta.xml.bind-api:4.0.0
Due to 4.0 support being added there is no easily available version of the XJC tool we can switch to that the plugin does not support. This is good news for the plugin project, but not this test. So it has been disabled. It should be possiblle to validate to test works if you wind back SCM history to somewhere between the time the IT was added and a commit or 2 before it was disabled.
This seems more correct when investigating Issue#34 concerning docLocale usage.
It is not entirely clear to me why using Locale type directly is better
than just keeping the setting as a string and converting it just before
use.
The Gradle documentation does indicate that anything Serializable can be
used as a Property, Locale is Serialiable so I'm not sure why it doesn't
work as-is.
It would be ideal if it was to be kept as Locale type and if both a Locale
or a String can be assigned to the property and it just works. But I
could not find out how to provide an accepted type convertor that works
in both Groovy and Kotlin DSLs.
The other alternative is to proivide a function like:
docLocale = locale('it')
docLocale = locale(Locale.ITALIAN)
It it not clear if the feature previously worked when set inside the DSL,
I was unable to create a TestCase that demonstrated it did. It only seemed
to work as a gradle.properties setting.
This commit does not change the previous behaviour with regards to
gradle.properties use, but it does allow it to be set from inside the DSL
now in a consistent way to the gradle.properties string property.
…otlin) From canary-consume testing, using newer JDK with Gradle 8.x will cause a configuration failure due to the mismatched target. Due to the JavaCompile inheriting the default of the JDK being used whilst kotlin output is locked.
…test-sets This is due to the 4.1.0 release (needed for Gradle 8.x) being release with Java11 bytecode compatiblity which affects validating CI with JDK8+Gradle8. So a release of 3.0.1, 4.0.0 and 4.1.0 exist under a new GAV and using GitHubPackages distribution point.
…ommentry Due to switch to org.darrylmiles.repack.org.unbroken-dome.test-sets
".... can't be called from this context by implicit receiver. Use the explicit one if necessary" Think it is an IDE issue using 1.9.21 capable editor against a 1.3 configured codebase?
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 2 to 3. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](actions/deploy-pages@v2...v3) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [jayanta525/github-pages-directory-listing](https://github.com/jayanta525/github-pages-directory-listing) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/jayanta525/github-pages-directory-listing/releases) - [Commits](jayanta525/github-pages-directory-listing@19ee734...624ac8c) --- updated-dependencies: - dependency-name: jayanta525/github-pages-directory-listing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This now matched spek-runner-junit5 version already in use.
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 3 to 4. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](actions/deploy-pages@v3...v4) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Main features: * JDK21 and Gradle 8.5 tested * Configuration Cache compatible (thanks Ryan Dens)
|
I updated my project from Java17 to Java21 and I am seeing this error which comes from a class generated by xjc.
Is this PR fixing issues with Java21? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update on #47
As per my comment #47 (comment) this is a reopened using a separate source branch at the origin repo.
Main features:
* JDK21 and Gradle 8.5 tested
* Configuration Cache compatible (thanks Ryan Dens)
* Removal of deprecated APIs (marked for removal in Gradle 9)
#51 org.gradle.util.GUtil
This was also released today as 2.2.0 over at the origin repo.