-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the Profile Page, Add Public Profiles #547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@KrisJordan - ready for review ![]() Fixed - added personal website and LinkedIn fields, moved edit button! |
KrisJordan
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added migration and verified locally. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigns the existing profile page to better conform to M3 standards, as well as adds support for access to public profiles. Public profiles are accessible at the route
/profile/:onyen
. The regular user profile page is at/profile
. If a user accesses/profile/:their-onyen
, the app redirects back to the regular profile page.New Profile Page Design
There is limited GitHub support on local, however the GitHub profile photo would be placed on the top left if the account is configured with GitHub. If configured, the handle shows up next to the GitHub icon under the name and there would be a button to unlink.
Backend Changes
There is now a protected URL to access any public user by onyen. There is also a new field called
bio
added to theuser
database table.Public Profiles
Clicking on organizers on the Events page now redirects you to that organizer's public profile. This will be added to the Welcome page when that is completed as well.
In the future, the public profile page will show organizations for which the user is a member, as well as articles they have written.