Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCurrentScreenObject() error on some custom screens #273

Closed
mleroi opened this issue Dec 14, 2016 · 0 comments
Closed

getCurrentScreenObject() error on some custom screens #273

mleroi opened this issue Dec 14, 2016 · 0 comments
Assignees
Milestone

Comments

@mleroi
Copy link
Collaborator

mleroi commented Dec 14, 2016

When displaying a custom screen, ThemeApp.getCurrentScreenObject() triggers an error in some cases.
We've seen the error when displaying a login form at app launch for example.
The error seems to be due to the fact that current_view.custom_page_data can be undefined here:
https://github.com/uncatcrea/wp-appkit/blob/master/wp-appkit/app/core/theme-app.js#L981

@mleroi mleroi added this to the 0.7 milestone Dec 14, 2016
@mleroi mleroi self-assigned this Dec 14, 2016
@blupu blupu added the theme label Mar 11, 2017
@blupu blupu modified the milestones: 0.7, 1.1 Mar 14, 2017
@mleroi mleroi modified the milestones: 1.1, 1.2 Jun 30, 2017
@mleroi mleroi modified the milestones: 1.1, 1.2 Jul 25, 2017
@mleroi mleroi closed this as completed in 2960c5c Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants