Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cefactBieDomainClass should be object prop not string #36

Closed
VladimirAlexiev opened this issue Jan 31, 2022 · 4 comments
Closed

cefactBieDomainClass should be object prop not string #36

VladimirAlexiev opened this issue Jan 31, 2022 · 4 comments
Assignees
@kshychko
Labels
NDR This is an issue which needs fixing on the transformation/graph creation

Comments

@VladimirAlexiev
Copy link

The link from BasicBIE to AggregateBIE should be an object prop, not a string:

cefact:WorkItem_QuantityAnalysis.Details
        rdf:type                        uncefact:AggregateBIE .
cefact:WorkItem_QuantityAnalysis.Identification.Identifier
        rdf:type                        uncefact:BasicBIE ;
        uncefact:cefactBieDomainClass   "cefact:WorkItem_QuantityAnalysis.Details" # -> cefact:WorkItem_QuantityAnalysis.Details
@nissimsan nissimsan added the NDR This is an issue which needs fixing on the transformation/graph creation label Mar 4, 2022
@nissimsan nissimsan added the v1 label May 27, 2022
@nissimsan
Copy link
Contributor

Related to #63

@nissimsan nissimsan assigned kshychko and unassigned onthebreeze Jun 23, 2022
@nissimsan
Copy link
Contributor

image

@Fak3
Copy link

Fak3 commented Jul 12, 2022

Related to #63

It is not related to #63. This issue is about metadata "hints" for humans we leave to keep the trace from which BIE the rdf class or property was generated.
To resolve this issue we should add proper type to our context:

"@context": {
   ...
   "unece:cefactBieDomainClass": {
     "@type": "@id"
   }
 }

@kshychko kshychko mentioned this issue Jul 14, 2022
Merged
@nissimsan
Copy link
Contributor

@kshychko fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshychko kshychko

Labels
NDR This is an issue which needs fixing on the transformation/graph creation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@VladimirAlexiev @Fak3 @kshychko @onthebreeze @nissimsan