Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order search #366

Merged
merged 5 commits into from
Jun 4, 2021
Merged

Order search #366

merged 5 commits into from
Jun 4, 2021

Conversation

Mikearaya
Copy link
Contributor

@Mikearaya Mikearaya commented May 25, 2021 •
edited

test search valid for

{ _id, userId,  orderNumber,  status  }

@Mikearaya Mikearaya requested a review from pozylon May 26, 2021 12:27
@Mikearaya Mikearaya marked this pull request as ready for review May 26, 2021 12:27
pozylon
pozylon reviewed May 26, 2021
View reviewed changes
Copy link
Member

@pozylon pozylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from index creation all looks good, I didn't check the UI yet though

packages/api/resolvers/queries/orders.js Outdated Show resolved Hide resolved
packages/core-orders/db/orders/schema.js Show resolved Hide resolved
@Mikearaya
Copy link
Contributor Author

@pozylon all is set, UI is straight you can take my word :)

@Mikearaya Mikearaya linked an issue May 27, 2021 that may be closed by this pull request
[FEATURE REQUEST] Search orders #319
Closed
@pozylon pozylon merged commit 0bb53c5 into master Jun 4, 2021
@pozylon pozylon deleted the order-search branch June 4, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pozylon pozylon pozylon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Search orders
2 participants
@Mikearaya @pozylon