-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Env fix #368
Conversation
.env-schema was not thought to be loaded by dotenv-extended as it's part of the root and should show all possible env's used while testing, running controlpanel and engine. I actually don't want to deactivate errorOnMissing because that's one of the most important features of dotenv-extended. What if we just remove it and build two new .env.schema in examples/minimal and examples/controlpanel? To suppress missing env error just set a default value with .env.defaults where possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment in conv
yes, that would get both things done |
the control panel only has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All nice and clean despite the suppress thing, after you can merge
damn, forgot after test 😦 |
Things adjusted
process.env.SUPPRESS_ENV_ERRORS
is not being read and it throws an error for missing config values or requests to put default values for each property in .env.schema