Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meta resolver #380

Merged
merged 15 commits into from
Aug 12, 2021
Merged

Remove meta resolver #380

merged 15 commits into from
Aug 12, 2021

Conversation

Mikearaya
Copy link
Contributor

@Mikearaya Mikearaya commented Jul 26, 2021

each payment provider should implement a type for PaymentCredential meta to be removed DataTrans, Strip, etc... because each expect different fields

@Mikearaya Mikearaya linked an issue Jul 27, 2021 that may be closed by this pull request
@Mikearaya Mikearaya marked this pull request as ready for review July 28, 2021 08:34
@Mikearaya Mikearaya requested a review from pozylon July 28, 2021 08:35
@pozylon
Copy link
Member

pozylon commented Aug 2, 2021

Documentation looks very good and else the changes are fine, which cases where we have arbitrary payload data that we have to generally make available to the frontend, still exist now? @Mikearaya

@Mikearaya
Copy link
Contributor Author

@pozylon yes, projects need to define their own explicit resolvers now and no meta field will be available for the listed types. meta will be available at a resolver definition point

@Mikearaya
Copy link
Contributor Author

Mikearaya commented Aug 2, 2021

is there anything you think should be added to this?

@Mikearaya
Copy link
Contributor Author

@pozylon

@pozylon
Copy link
Member

pozylon commented Aug 12, 2021

Meta Usage Today by the big shops:

  • Order.meta
  • Assortment.meta
  • OrderDelivery.meta

@pozylon
Copy link
Member

pozylon commented Aug 12, 2021

I fixed some things with controlpanel and removed the order meta props, tests all running through

@pozylon pozylon merged commit 6752725 into master Aug 12, 2021
@pozylon pozylon deleted the remove-meta-resolver branch August 12, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order.meta resolver private or not?
2 participants