Fix Assortment Paths

[pozylon]

…ssortments.findOne

[pozylon]

Issues with consistency:

• createAssortmentLink and createAssortmentProduct do not check if the provided childAssortmentId or productId exist
• the helpers addLink and addProduct (+ addFilter, ...) on assortment call createAssortmentLink/createAssortmentProduct respectively, also without checking if provided data results in failed links
• the mutation that call addLink, addProduct and addFilter ARE CHECKING THAT IT'S VALID
• the bulk importer DOES NOT check if data is valid so a wrong bulk import event could lead to crap data in the db
• Filters.removeFilter does not remove AssortmentFilters but completely removed Filters from the db

This could lead to broken breadcrumbs and exceptions because the GraphQL Schema state that assortmentProduct on ProductAssortmentPath and assortmentId/assortmentTexts are NON-NULL and AssortmentLink, AssortmentFilter and AssortmentProduct state that the edges are NON-NULL

How to solve this?

a) Fix on edit

• We add existence checks to the bulk importer
• Add a cleanup migration
• Fix removing filters does not remove AssortmentFilters
• Fix removing products does not remove AssortmentProducts

b) Relax the graphql schema

• Make all NON-NULL references of products, assortments and filters NULLABLE

Going with B is like sending the rotten tomato to the client, shall the client deal with the mess. We should always try to keep the DB as consistent as possible so we should do A.

[Mikearaya]

looks good to me 👍