Cryptopay Payment & Pricing Plugin #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to track the derived addresses for these transactions
pozylon
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Very nice! can you please:
- add some documentation on how to use the payment plugins in conjunction with crypto pay
- add some documentation on how to use the rate providing functions
- and write a changelog entry stating what core features have been added (rate stuff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment & pricing plugins for the crypto payment gateway. For the pricing plugin, the main business logic is implemented by the generic
ProductPriceRateConversionplugin which consumes the rates in the database with theproducts.prices.ratesmodule. The rates in the database are produced by the web hook calls.The same pattern can be used for the Coinbase / ECB plugins such that they only feed the rates in the DB, but do not contain any business logic.
The payment plugin supports payments for products that have a crypto price or for products that only have a fiat price (in this case, the new rate plugin is used for conversion, so the plugin can also be used in conjunction with different rate providers).