Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GridFS File Adapter and refactor files and file-upload packages #425

Merged
merged 12 commits into from
Feb 26, 2022
Merged

Add GridFS File Adapter and refactor files and file-upload packages #425

merged 12 commits into from
Feb 26, 2022

Conversation

pozylon
Copy link
Member

@pozylon pozylon commented Feb 25, 2022

No description provided.

@pozylon pozylon mentioned this pull request Feb 25, 2022
Closed
8 tasks
@pozylon
Copy link
Member Author

pozylon commented Feb 25, 2022

Missing: removeFiles in zombie killer

@OpenCoreCH
Copy link
Contributor

@pozylon Very nice! I added some minor comments and I think you missed the await for one initDb call in delivery-index.test.ts, looks otherwise good to me.

@pozylon pozylon merged commit b24b4a3 into master Feb 26, 2022
@pozylon pozylon deleted the gridfs branch February 28, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenCoreCH OpenCoreCH OpenCoreCH left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pozylon @OpenCoreCH