Skip to content

Commit

Permalink
Move shared table events out into shared macro
Browse files Browse the repository at this point in the history
  • Loading branch information
alcwhite committed Nov 3, 2021
1 parent a8bf977 commit 04853a9
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 60 deletions.
13 changes: 1 addition & 12 deletions uncharted_phoenix/lib/uncharted_phoenix/components/live_bar.ex
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ defmodule UnchartedPhoenix.LiveBarComponent do
"""

use Phoenix.LiveComponent

def mount(socket) do
{:ok, assign(socket, :show_table, false)}
end
use UnchartedPhoenix.TableEvents

def update(assigns, socket) do
x_axis = assigns.chart.dataset.axes.magnitude_axis
Expand Down Expand Up @@ -36,12 +33,4 @@ defmodule UnchartedPhoenix.LiveBarComponent do
def render(assigns) do
Phoenix.View.render(UnchartedPhoenix.ComponentView, "live_bar.html", assigns)
end

def handle_event("show_table", _, socket) do
{:noreply, assign(socket, :show_table, true)}
end

def handle_event("hide_table", _, socket) do
{:noreply, assign(socket, :show_table, false)}
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ defmodule UnchartedPhoenix.LiveColumnComponent do
"""

use Phoenix.LiveComponent

def mount(socket) do
{:ok, assign(socket, :show_table, false)}
end
use UnchartedPhoenix.TableEvents

def update(assigns, socket) do
y_axis = assigns.chart.dataset.axes.magnitude_axis
Expand All @@ -32,12 +29,4 @@ defmodule UnchartedPhoenix.LiveColumnComponent do
def render(assigns) do
Phoenix.View.render(UnchartedPhoenix.ComponentView, "live_column.html", assigns)
end

def handle_event("show_table", _, socket) do
{:noreply, assign(socket, :show_table, true)}
end

def handle_event("hide_table", _, socket) do
{:noreply, assign(socket, :show_table, false)}
end
end
13 changes: 1 addition & 12 deletions uncharted_phoenix/lib/uncharted_phoenix/components/live_line.ex
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ defmodule UnchartedPhoenix.LiveLineComponent do
"""

use Phoenix.LiveComponent

def mount(socket) do
{:ok, assign(socket, :show_table, false)}
end
use UnchartedPhoenix.TableEvents

def update(assigns, socket) do
x_axis = assigns.chart.dataset.axes.x
Expand Down Expand Up @@ -41,12 +38,4 @@ defmodule UnchartedPhoenix.LiveLineComponent do
def render(assigns) do
Phoenix.View.render(UnchartedPhoenix.ComponentView, "live_line.html", assigns)
end

def handle_event("show_table", _, socket) do
{:noreply, assign(socket, :show_table, true)}
end

def handle_event("hide_table", _, socket) do
{:noreply, assign(socket, :show_table, false)}
end
end
13 changes: 1 addition & 12 deletions uncharted_phoenix/lib/uncharted_phoenix/components/live_pie.ex
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ defmodule UnchartedPhoenix.LivePieComponent do
"""

use Phoenix.LiveComponent

def mount(socket) do
{:ok, assign(socket, :show_table, false)}
end
use UnchartedPhoenix.TableEvents

def update(assigns, socket) do
socket =
Expand All @@ -22,12 +19,4 @@ defmodule UnchartedPhoenix.LivePieComponent do
def render(assigns) do
Phoenix.View.render(UnchartedPhoenix.ComponentView, "live_pie.html", assigns)
end

def handle_event("show_table", _, socket) do
{:noreply, assign(socket, :show_table, true)}
end

def handle_event("hide_table", _, socket) do
{:noreply, assign(socket, :show_table, false)}
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ defmodule UnchartedPhoenix.LiveProgressComponent do

alias Uncharted.ProgressChart
use Phoenix.LiveComponent

def mount(socket) do
{:ok, assign(socket, :show_table, false)}
end
use UnchartedPhoenix.TableEvents

def update(assigns, socket) do
socket =
Expand All @@ -24,12 +21,4 @@ defmodule UnchartedPhoenix.LiveProgressComponent do
def render(assigns) do
Phoenix.View.render(UnchartedPhoenix.ComponentView, "live_progress.html", assigns)
end

def handle_event("show_table", _, socket) do
{:noreply, assign(socket, :show_table, true)}
end

def handle_event("hide_table", _, socket) do
{:noreply, assign(socket, :show_table, false)}
end
end
17 changes: 17 additions & 0 deletions uncharted_phoenix/lib/uncharted_phoenix/table_events.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
defmodule UnchartedPhoenix.TableEvents do
defmacro __using__(_) do
quote do
def mount(socket) do
{:ok, assign(socket, :show_table, false)}
end

def handle_event("show_table", _, socket) do
{:noreply, assign(socket, :show_table, true)}
end

def handle_event("hide_table", _, socket) do
{:noreply, assign(socket, :show_table, false)}
end
end
end
end

0 comments on commit 04853a9

Please sign in to comment.