Infinite loop

[blling]

I run into a infinite loop after upgrade to fitnesse-20181223, i found the thread is busy with method readAndParseRequestLine, which is changed by commit 4078f4e#diff-0e2a986db526e0ce77e3e3747199b0dbR72.

fitnesse-20181221 is OK

jstack screenshot is here:

[fhoeben]

That is unfortunate. I'll try to make a fix asap.
Anything in particular you are doing at the time this loop occurs?

[fhoeben]

What is the behaviour of FitNesse because of this loop? Does it hang, or ...?

I believe the code you refer to is only an infinite loop if there is a client that keeps sending newlines to FitNesse. That might be a browser that tries to keep a connection open. I would expect that to eventually send a real request...

[blling]

After a try use sample-fitnesse-project, it seems browser releated, Chrome is OK, Firefox is NG.

I reproduce it in the follow steps:

Clone sample-fitnesse-project -> mvn exec:exec -> open http://localhost:9090 in Firfox.

then the cpu is up, if you refresh the page n times，the cpu is up to 100*n

Firfox version:

[fhoeben]

I see the behaviour now. Indeed I'm able to reproduce with Firefox.
Safari does not seem to have the problem,.

[blling]

@fhoeben Thanks for your quick fix. 👍
Upgrade to fitnesse-20181224 is OK now.