Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 20190224 does not display test results properly in Internet Explorer 11 #1196

Closed
Rhialto74 opened this issue Mar 20, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@Rhialto74
Copy link

commented Mar 20, 2019

I recently updated our Fitnesse install to the 20190224 and it seems our test results do not display properly in Internet Explorer 11, while they do in Chrome. I can navigate to the pages fine, but if I run a test they fail in IE and go to the generic not found error page.

I downgraded to 20190202 and that works fine.

When I traced the issue it appears that the request data being returned to IE in the later version does not contain the closing </footer>, </body> and </html> tags.

@fhoeben

This comment has been minimized.

Copy link
Collaborator

commented Mar 20, 2019

Very strange indeed. @tcnh, do you think this might have something to do with #1189?
I don't see how that would work (maybe because now closeChunks() is called before closeTrailer()?), but...

@tcnh

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

I'm looking in to it, but can't figure it out just yet. The mentioned change doesn't skip any html, just a CRLF.
What I can see is that the closing tags for footer, body and html are sent in the output bytestream. I'll install a VM with IE11 tonight to try and reproduce.

@Rhialto74 You say you're redirected to the notFound responder? If the output were incomplete I'd expect an empty page in IE11..

@Rhialto74

This comment has been minimized.

Copy link
Author

commented Mar 21, 2019

@tcnh

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

I am able to reproduce and can confirm the problem disappears when closeTrailer is called twice. What happens if we don't call it twice, the response ends with 0 CRLF, if we don't it ends with CRLF. The first one breaks IE11.

Changing the order of actions in ChunkedResponse.close() from closeChunks -> closeTrailer -> sender.close to closeTrailer -> closeChunks -> sender.close resolves the issue, but I can not test if that also prevents the exception in debian-based OS-es from #1187 right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.