Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purging the testHistory fails when using Subversion / Git #600

Closed
aphofstede opened this issue Jan 27, 2015 · 7 comments
Closed

Purging the testHistory fails when using Subversion / Git #600

aphofstede opened this issue Jan 27, 2015 · 7 comments
Milestone

Comments

@aphofstede
Copy link

See also: http://sourceforge.net/p/fitnesse/bugs/24/

When FitNesse is under Version Control with Subversion, the purging of the testHistroy fails.
This is because Subversion adds a .svn directory in every directory of FitNesse.
The Purge now scans the .svn directory too and wants the delete the files in the .svn directory.
This causes a ParseException.
The .svn directory should not be included when purging the testHistory.

Same applies for git.

@mwarhaftig
Copy link
Contributor

Looks like as of Subversion 1.7 (released 10/2011) only the working directory gets a .svn subdirectory (http://stackoverflow.com/questions/9070190/svn-no-longer-writes-svn-in-all-sub-folders). Also, all Git releases only add a .git file to the top level directory.

This limits the chances of testHistory having a .svn or git subdirectory but obviously it can happen. Let me see if I can find a good way to handle these files.

@linquize
Copy link
Contributor

Do you mean to run git clean -fxd?

mwarhaftig added a commit to mwarhaftig/fitnesse that referenced this issue Mar 30, 2015
@mwarhaftig
Copy link
Contributor

Referenced pull request updates testHistory purge logic to remove hidden subdirectories if all other files within directory will be purged.

@amolenaar
Copy link
Collaborator

I was just wondering. FitNesse does not create any directories in the directories that contain the history xml files. Shouldn't we just leave directories alone? Not removing the test history directory. I mean: if people (or other tools for that matter) put extra stuff in those folders it's their problem right? We can just leave it be.

@mwarhaftig
Copy link
Contributor

My reason for deleting hidden directories was to prevent older SVN versions from permanently having empty testResults subdirectories for all run tests.

But I don't have strong feelings about the need to delete...

@mwarhaftig
Copy link
Contributor

@amolenaar currently whenever the purge encounters a file that is not test history it logs a severe error since it doesn't know if it should delete that file. Should we just not log non-test history files as an error?

@amolenaar
Copy link
Collaborator

I think we should not use severe errors then. Just leave them be, maybe log a warning (or on info level), since we do not expect such files to be there?

mwarhaftig added a commit to mwarhaftig/fitnesse that referenced this issue Apr 7, 2015
mwarhaftig added a commit to mwarhaftig/fitnesse that referenced this issue Apr 8, 2015
amolenaar added a commit that referenced this issue Apr 15, 2015
Issue #600 - Lowered Purger non-test history file message to INFO.
@amolenaar amolenaar added this to the Next release milestone Apr 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants