A SuiteQuery should not run test pages that are excluded #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y match the query.
NicoleRauch
force-pushed
the
exclude_skipped_in_suite_query
branch
from
5656eab
to
d9a1138
Compare
|
+1 |
|
Thanks :) |
amolenaar
added a commit
to fitnesse/fitnesse
that referenced
this pull request
Nov 27, 2017
…suite_query A SuiteQuery should not run test pages that are excluded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation: When a test page is skipped, and there is a SuiteQuery that matches this page, it will execute the page although it is skipped.
This pull request addresses this situation and makes the SuiteQuery ignore skipped tests.
Note: Although the skipping is meant to be recursive, the SuiteQuery does not yet ignore children of a skipped test. This is a bit more complicated, and I will try to work on it. But I think even this small improvement is worthwhile, therefore I'm sending it as an individual PR.