Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A SuiteQuery should not run test pages that are excluded #1079

Merged

Conversation

@NicoleRauch
Copy link
Contributor

@NicoleRauch NicoleRauch commented Sep 4, 2017

Current situation: When a test page is skipped, and there is a SuiteQuery that matches this page, it will execute the page although it is skipped.

This pull request addresses this situation and makes the SuiteQuery ignore skipped tests.

Note: Although the skipping is meant to be recursive, the SuiteQuery does not yet ignore children of a skipped test. This is a bit more complicated, and I will try to work on it. But I think even this small improvement is worthwhile, therefore I'm sending it as an individual PR.

@amolenaar amolenaar added this to the Next Release milestone Oct 15, 2017
@NicoleRauch NicoleRauch force-pushed the exclude_skipped_in_suite_query branch from 5656eab to d9a1138 Nov 15, 2017
@jdufner
Copy link
Contributor

@jdufner jdufner commented Nov 23, 2017

+1

@amolenaar
Copy link
Collaborator

@amolenaar amolenaar commented Nov 27, 2017

Thanks :)

@amolenaar amolenaar merged commit d9a1138 into unclebob:master Nov 27, 2017
amolenaar added a commit to fitnesse/fitnesse that referenced this issue Nov 27, 2017
…suite_query

A SuiteQuery should not run test pages that are excluded
@NicoleRauch NicoleRauch deleted the exclude_skipped_in_suite_query branch Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants