Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suites consisting of symbolic pages #1218

Merged
merged 1 commit into from Apr 20, 2019

Conversation

jan-z
Copy link
Contributor

@jan-z jan-z commented Apr 20, 2019

If using a Suite-page that uses symlinks to link to different external
roots, starting with commit 16bb43e only the contents of the first
symlinked page was displayed in the output of "!contents".

This regression was introduced by fixing #925.

If using a Suite-page that uses symlinks to link to different external
roots, starting with commit 16bb43e only the contents of the first
symlinked page was displayed in the output of "!contents".

This regression was introduced by fixing unclebob#925.
@fhoeben fhoeben merged commit 286d586 into unclebob:master Apr 20, 2019
fhoeben added a commit that referenced this pull request Apr 20, 2019
@jan-z jan-z deleted the fix-SymbolicSuites branch April 20, 2019 08:27
@jan-z
Copy link
Contributor Author

jan-z commented Apr 20, 2019

Thanks for merging. This bug has been keeping us from upgrading for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants