Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize expression evaluator #1220

Merged
merged 3 commits into from Apr 29, 2019

Conversation

@tcnh
Copy link
Contributor

commented Apr 25, 2019

Add only symbols referenced in the expression to the evaluator's context. This results in up to 40% less consumed time evaluating expressions on pages that have a large amount of slim symbols in their scope.

Also, catch any exception from ParseUtil, as it can trip over localized characters encoded with %'s causing it to throw runtime exceptions that don't need specific handling (if we can't parse the string as html, we treat it as a string)

tcnh added 2 commits Apr 25, 2019
Add only symbols that are referenced in the expression to the evaluat…
…or context;

catch all exceptions from parseUtil when converting maps to prevent evaluator from failing when parseUtil trips over localized encoding
Update src/fitnesse/slim/SlimExpressionEvaluator.java
Co-Authored-By: tcnh <tom.heintzberger@gmail.com>

@fhoeben fhoeben merged commit d33f7b0 into unclebob:master Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.