Optimize expression evaluator #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or context; catch all exceptions from parseUtil when converting maps to prevent evaluator from failing when parseUtil trips over localized encoding
fhoeben
reviewed
Apr 28, 2019
Co-Authored-By: tcnh <tom.heintzberger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add only symbols referenced in the expression to the evaluator's context. This results in up to 40% less consumed time evaluating expressions on pages that have a large amount of slim symbols in their scope.
Also, catch any exception from ParseUtil, as it can trip over localized characters encoded with %'s causing it to throw runtime exceptions that don't need specific handling (if we can't parse the string as html, we treat it as a string)