Remove global slim timeout during testing #660
Conversation
Before everything parsed in SLIM_FLAGS was treated as one additional argument to the SlimService. Now SLIM_FLAGS is split after each white-space character into distinct parameters.
Fixes the problem that long running tests are stopped after slim.timeout seconds.
New class for testing timeout in slim test acceptance test suite.
|
I created a few acceptance tests in the timeout branch on my fork. That might be useful. See #662. |
|
Are you limiting the slim.timeout property to only be used while loading the test system? |
Both suites are marked as "skip" at the moment. The slim.timeout flag doesn't works as assumed. The suite for startup runs nice in interactive mode but fails when run from ant. Input to fix this welcome.
|
I expected this as well. But testing shows it is not the case. There is a workaround using SLIM_FLAGS. But also then the timeout doesn't seems to be useful as every testcase will fail afterwards. I added the usage of slim.timeout while waiting for the SlimHeader message. The remaing usage of slim.timeout is unchanged. |
Conflicts: src/fitnesse/testsystems/slim/SlimCommandRunningClient.java
Move the suite under SuiteSlimTests and removed includes which are not required in this location
|
Fixed the merge conflict to allow automatic merge. |
| String slimFlags = getVariable("slim.flags"); | ||
| if (slimFlags == null) { | ||
| slimFlags = getVariable(SLIM_FLAGS); | ||
| } | ||
| return slimFlags == null ? "" : slimFlags; | ||
| return slimFlags == null ? new String[] {} : slimFlags.trim().split("\\s"); |
There was a problem hiding this comment.
There is a smarter parser in ClientBuilder.parseCommandLine(). That will take into account quoted values.
There was a problem hiding this comment.
Thanks for the hint. Changed it.
Reuse existing method parseCommandLine to parse slim.flags. Supports parameters in quotes.
Remove global slim timeout during testing
This fixes #657 #656 #653
also fixes a bug with multiple arguments in SLIM_FLAGS.
I started preparing automatic test cases. They will follow shortly.