Revert old behaviour for Slim String converter

[amolenaar]

String converter used to pass strings as is. The 20150226 version converts empty Strings to null values.

This PR reverts the old behaviour.

[mgaertne]

What about a feature flag to smooth out the transition here?

Best Markus

Dipl.-Inform. Markus Gärtner
Author of ATDD by Example - A Practical Guide to Acceptance
Test-Driven Development

http://www.shino.de/blog
http://www.mgaertne.de
http://www.it-agile.de
Twitter: @mgaertne

On 21.03.2015, at 17:44, Arjan Molenaar notifications@github.com wrote:

String converter used to pass strings as is. The 20150226 version converts empty Strings to null values.

This PR reverts the old behaviour.

You can view, comment on, or merge this pull request online at:

#687

Commit Summary

String converter should return empty string if empty string is provided. This is different from any other converter. Fixes #686.
File Changes

M src/fitnesse/slim/converters/StringConverter.java (2)
M test/fitnesse/slim/ConverterSupportTest.java (2)
M test/fitnesse/slim/ListExecutorTestBase.java (4)
M test/fitnesse/slim/converters/StringConverterTest.java (25)
Patch Links:

https://github.com/unclebob/fitnesse/pull/687.patch
https://github.com/unclebob/fitnesse/pull/687.diff
—
Reply to this email directly or view it on GitHub.

[davidmagill]

Are you suggesting that this should be the intended behavior? If so, I would ask the following:

If the setter method expects a string value, why should an empty cell pass it null? Also, I'm not sure how you would pass an empty string if that was required behavior...

The new behavior breaks backward compatibility.

[amolenaar]

Merged, as agreed by @antoine-aumjaud.