New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #698: tag filtering is case insensitive #728

Merged
merged 2 commits into from May 20, 2015

Conversation

Projects
None yet
2 participants
@jruijgers
Contributor

jruijgers commented May 1, 2015

in the original code the tag filter was caseinsentive and with the introduction of the exclude filter this was implemented wrongly

Change-Id: I7ec37f74e5f3015a647651d4f61ae8273d2bf2a7

Jeroen Ruijgers
fixes #698: tag filtering is case insensitive
in the original code the tag filter was caseinsentive and with the introduction of the exclude filter this was implemented wrongly

Change-Id: I7ec37f74e5f3015a647651d4f61ae8273d2bf2a7
@amolenaar

This comment has been minimized.

Show comment
Hide comment
@amolenaar

amolenaar May 6, 2015

Collaborator

I think this behaviour requires a test :)

Collaborator

amolenaar commented May 6, 2015

I think this behaviour requires a test :)

@amolenaar amolenaar added this to the Next release milestone May 6, 2015

Jeroen Ruijgers
added test case
Change-Id: If251dd92c0114bbbaafc3d9c73eb7b715c9731f7
@jruijgers

This comment has been minimized.

Show comment
Hide comment
@jruijgers

jruijgers May 8, 2015

Contributor

Some unit tests are added

Contributor

jruijgers commented May 8, 2015

Some unit tests are added

@amolenaar amolenaar merged commit 7b06ff3 into unclebob:master May 20, 2015

amolenaar added a commit that referenced this pull request May 20, 2015

@jruijgers jruijgers deleted the jruijgers:698_suitefilter_casesensitivity branch Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment