Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utf 8 characters in symbols #791

Merged
merged 1 commit into from Sep 24, 2015

Conversation

hcf
Copy link
Contributor

@hcf hcf commented Sep 17, 2015

Making sure we are able to parse symbols containing utf-8 characters.

Making sure we are able to parse symbols containing utf-8 characters.
@amolenaar amolenaar added this to the Next release milestone Sep 24, 2015
@amolenaar amolenaar merged commit 8409885 into unclebob:master Sep 24, 2015
amolenaar added a commit that referenced this pull request Sep 24, 2015
@six42
Copy link
Contributor

six42 commented Sep 25, 2015

Hi @hcf ,

How do you retrieve the symbols you set with UTF character?
if I didn't missed anything you just changed the assignment pattern but not the retrieval pattern.
What is your use case? Can you provide a wiki testpage?

@hcf
Copy link
Contributor Author

hcf commented Sep 25, 2015

Hi @six42 and @amolenaar. You are indeed correct in that my PR is not working correctly. I have added failing tests now, and should be easy enough to fix in my PR, or should I create a new PR or #779?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants