Fix various warnings and minor issues #808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've left an open question regarding the unused local variable in PageHistoryResponder. There's a section of the code which spends time and effort assign a value to this variable, but it is never used for anything. I don't know what the intended behaviour here is, because it could be that the value should be used for something, or that the traversing cause some side-effects which are needed here, or potentially that the section is unnecessary and could be removed.