Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various warnings and minor issues #808

Merged
merged 9 commits into from Oct 4, 2015
Merged

Conversation

hansjoachim
Copy link
Contributor

  • Fixed some more unused imports.
  • Add parameters to a raw Map based on its usage.
  • Removed some unused methods.
  • Removed some unused fields. (Note that there's an optional commit which reduces visibility for an inner class in a test suite which made it possible to remove more unused methods and fields from it.)

I've left an open question regarding the unused local variable in PageHistoryResponder. There's a section of the code which spends time and effort assign a value to this variable, but it is never used for anything. I don't know what the intended behaviour here is, because it could be that the value should be used for something, or that the traversing cause some side-effects which are needed here, or potentially that the section is unnecessary and could be removed.

@hansjoachim hansjoachim mentioned this pull request Oct 3, 2015
@amolenaar amolenaar added this to the Next release milestone Oct 4, 2015
amolenaar added a commit that referenced this pull request Oct 4, 2015
Fix various warnings and minor issues
@amolenaar amolenaar merged commit ea9ec01 into unclebob:master Oct 4, 2015
@hansjoachim hansjoachim deleted the issues branch October 4, 2015 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants