All scenario resolution in test context #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test context (where basic scenario finding was already)
… the test context
amolenaar
reviewed
Sep 17, 2016
| @@ -18,6 +18,8 @@ | |||
|
|
|||
| ScenarioTable getScenario(String scenarioName); | |||
|
|
|||
| ScenarioTable getScenarioByPatternMatching(String invokingString, CustomComparatorRegistry customComparatorRegistry); | |||
There was a problem hiding this comment.
I think getScenarioByPattern is a more appropriate name.
| @@ -330,6 +334,11 @@ public ScenarioTable getScenario(String scenarioName) { | |||
| } | |||
|
|
|||
| @Override | |||
| public ScenarioTable getScenarioByPatternMatching(String invokingString, CustomComparatorRegistry customComparatorRegistry) { | |||
There was a problem hiding this comment.
Same method rename here.
…to re-sort unless the list has changed.
… a few of the elements must be re-ordered. In this case only the scenarios added since the last time we sorted.
|
Renamed as suggested, and added small optimization: no need to sort the scenarios for each lookup |
…ased on single cell parsing (the ones without arguments are found based on their name alone)
…or hashmap and 8 for list) since the number of scenarios could be much larger and resizing collections is much more expensive than having/allocating larger ones for each test.
…s needed (i.e. the first time a single cell script table row is encountered)
…, not to determine what the arguments are
… looking at all odd cells in the row
amolenaar
added a commit
that referenced
this pull request
Oct 9, 2016
All scenario resolution in test context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves all scenario resolution logic to the slim test context.
Furthermore it only creates the pattern to match a single cell scenario call with parameters once, instead of each time the scenario is evaluated to determine whether it matches.