Fix dropdown fields #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed BootstrapDropdownField to avoid conflicts with with DropdownField and ChosenDropdownfield. BootstrapDropdownField: Changed to render with default Dropdownfield.ss template. Use bootstrap-select JS plugin by adding ExtraClass 'selectpicker'. Add option bootstrap_select_included to config.yml ChosenDropdownField Include/add chosen v1.6.2 library With bootstrap_included set to false: load silverstripe thirdparty jquery and /admin/thirdparty/chosen/chosen/chosen.jquery.js With bootstrap_included set to true: load chosen v1.6.2 (silverstripe bundled version /admin/thirdparty/chosen/chosen/chosen.jquery.js uses jQuery.browser() method which removed since jQuery 1.9 – but Bootstrap 3.3.6 and above requires jQuery 1.9.1+) caveats: BootstrapDropdownField can't be used with jquery_included set to false, as this will include the ss-bundled version which is too low. To use BootstrapDropdownField you will need to include jQuery 1.9.1+ (Bootstrap 3.3 and above requires 1.9.1+ anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed BootstrapDropdownField to avoid conflicts with DropdownField and ChosenDropdownfield.
BootstrapDropdownField:
Changed to render with default Dropdownfield.ss template.
Use bootstrap-select JS plugin by adding ExtraClass 'selectpicker'.
Add option bootstrap_select_included to config.yml
ChosenDropdownField
Include/add chosen v1.6.2 library
With bootstrap_included set to false: load silverstripe thirdparty jquery and /admin/thirdparty/chosen/chosen/chosen.jquery.js
With bootstrap_included set to true: load chosen v1.6.2 (silverstripe bundled version /admin/thirdparty/chosen/chosen/chosen.jquery.js uses jQuery.browser() method which is removed since jQuery 1.9 – but Bootstrap 3.3.6 and above requires jQuery 1.9.1+)
caveats:
BootstrapDropdownField can't be used with jquery_included set to false, as this will include the ss-bundled version which is too low.
To use BootstrapDropdownField you will need to include jQuery 1.9.1+ (Bootstrap 3.3.x requires 1.9.1+ anyway)