Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite nasty regex HTML parser #25

Closed
lewiscollard opened this issue Dec 5, 2022 · 0 comments
Closed

Rewrite nasty regex HTML parser #25

lewiscollard opened this issue Dec 5, 2022 · 0 comments
Labels
1.0 fix before first public release cleanup

Comments

@lewiscollard
Copy link
Collaborator

lewiscollard commented Dec 5, 2022 •
edited
Loading

It did the job, and somehow hasn't ever broken in the history of UnCMS's ancestors. But we're still parsing HTML with regular expressions, and we really ought not do that, especially when we already have BeautifulSoup as a dependency.

There was a previous attempt to fix this in UnCMS's immediate ancestor.
@lewiscollard lewiscollard added cleanup 1.0 fix before first public release labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 fix before first public release cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lewiscollard