Remove Regex HTML parsing and use beautiful soup instead. #156
Conversation
|
Builds failed as BeautifulSoup4 4.6.3 seems to remove the closing backslash. Downgrading to 4.6.0 for the time being. |
This is fine - it's consistent with everything else to avoid the XML style of void elements. Feel free to fix those tests and bump the Soup version to the latest. |
cms/html.py
Outdated
| attrs["height"] = '"%s"' % thumbnail.height | ||
| else: | ||
| assert False | ||
| return str(soup.decode(formatter=None)) |
There was a problem hiding this comment.
Should six.text_type(soup) be fine here? (Or str(soup) whenever we remove Python 2 support.)
There was a problem hiding this comment.
From the docs:
If you pass in formatter=None, Beautiful Soup will not modify strings at all on output. This is the fastest option, but it may lead to Beautiful Soup generating invalid HTML/XML[.]
There was a problem hiding this comment.
it's formatter=None at the moment as otherwise soup turns the © into ©
No description provided.