Add support for universal contiguous? function.

project.clj

@@ -49,7 +49,7 @@
                                  *assert* false
                                  *unchecked-math* :warn-on-boxed
                                  *print-length* 128}
-                   :dependencies [[midje "1.9.8"]]}}
+                   :dependencies [[midje "1.9.9"]]}}
 
   :javac-options ["-target" "1.8" "-source" "1.8" "-Xlint:-options"]
   :source-paths ["src/clojure" "src/device"]

src/clojure/uncomplicate/neanderthal/block.clj

@@ -26,8 +26,8 @@
 (defn row? [a]
   (.isRowMajor (api/navigator a)))
 
-(defn gapless? [a]
-  (.isGapless (api/storage a)))
+(defn contiguous? [^Block x]
+  (.isContiguous x))
 
 (defn wrap-prim [^DataAccessor accessor ^double v]
   (.wrapPrim accessor v))

src/clojure/uncomplicate/neanderthal/internal/device/clblock.clj

@@ -248,6 +248,8 @@
     ofst)
   (stride [_]
     strd)
+  (isContiguous [_]
+    (= 1 strd))
   (dim [_]
     n)
   (boxedEntry [x i]
@@ -478,6 +480,8 @@
     ofst)
   (stride [_]
     (.ld stor))
+  (isContiguous [_]
+    (.isGapless stor))
   (dim [_]
     (* m n))
   (mrows [_]
@@ -697,6 +701,8 @@
     ofst)
   (stride [_]
     (.ld stor))
+  (isContiguous [_]
+    false)
   (dim [_]
     (* n n))
   (mrows [_]

src/clojure/uncomplicate/neanderthal/internal/device/cublock.clj

@@ -302,6 +302,8 @@
     ofst)
   (stride [_]
     strd)
+  (isContiguous [_]
+    (= 1 strd))
   (dim [_]
     n)
   (boxedEntry [x i]
@@ -518,6 +520,8 @@
     ofst)
   (stride [_]
     (.ld stor))
+  (isContiguous [_]
+    (.isGapless stor))
   (dim [_]
     (* m n))
   (mrows [_]
@@ -705,6 +709,8 @@
     ofst)
   (stride [_]
     (.ld stor))
+  (isContiguous [_]
+    false)
   (dim [_]
     (* n n))
   (mrows [_]

src/clojure/uncomplicate/neanderthal/internal/host/buffer_block.clj

@@ -466,6 +466,8 @@
     ofst)
   (stride [_]
     strd)
+  (isContiguous [_]
+    (= 1 strd))
   (dim [_]
     n)
   (entry [_ i]
@@ -671,6 +673,8 @@
     ofst)
   (stride [_]
     strd)
+  (isContiguous [_]
+    (= 1 strd))
   (dim [_]
     n)
   (entry [_ i]
@@ -930,6 +934,8 @@
     ofst)
   (stride [_]
     (.ld stor))
+  (isContiguous [_]
+    (.isGapless stor))
   (dim [_]
     (* m n))
   (mrows [_]
@@ -1183,6 +1189,8 @@
     ofst)
   (stride [_]
     (.ld stor))
+  (isContiguous [_]
+    false)
   (dim [_]
     (* n n))
   (mrows [_]
@@ -1489,6 +1497,8 @@
     ofst)
   (stride [_]
     (.ld stor))
+  (isContiguous [_]
+    (.isGapless stor))
   (dim [_]
     (* m n))
   (mrows [_]
@@ -2069,6 +2079,8 @@
     ofst)
   (stride [_]
     1)
+  (isContiguous [_]
+    true)
   (dim [_]
     (* n n))
   (mrows [_]

src/java/uncomplicate/neanderthal/internal/api/Block.java

@@ -16,4 +16,5 @@ public interface Block {
 
     long stride ();
 
+    boolean isContiguous ();
 }

test/uncomplicate/neanderthal/block_test.clj

@@ -14,7 +14,7 @@
              [test :refer :all]]
             [uncomplicate.neanderthal
              [core :refer :all]
-             [block :refer [buffer]]])
+             [block :refer [buffer contiguous?]]])
   (:import  [clojure.lang IFn$LLD IFn$LD IFn$DD ExceptionInfo]))
 
 (defn test-create [factory]
@@ -129,6 +129,32 @@
      (transfer! b1 a0) => a2
      (transfer! a2 b0) => b2)))
 
+(defn test-vctr-contiguous [factory]
+  (let [x (vctr factory 4)
+        a (ge factory 4 4 (range 16))]
+    (facts
+     "Vector contiguous tests."
+     (contiguous? x) => true
+     (contiguous? (row a 0)) => false
+     (contiguous? (row a 1)) => false
+     (contiguous? (col a 0)) => true
+     (contiguous? (col a 1)) => true)))
+
+(defn test-ge-contiguous [factory]
+  (let [a (ge factory 4 4 (range 16))]
+    (facts
+     "GE contiguous tests."
+     (contiguous? a) => true
+     (contiguous? (submatrix a 0 0 4 2)) => true
+     (contiguous? (submatrix a 0 1 4 2)) => true
+     (contiguous? (submatrix a 0 1 3 2)) => false)))
+
+(defn test-uplo-contiguous [factory uplo]
+  (let [a (uplo factory 4 (range 16))]
+    (facts
+     "Uplo contiguous tests."
+     (contiguous? a) => false)))
+
 ;; ================= Vector  ========================================
 
 (defn test-vctr-ifn [factory]
@@ -444,14 +470,18 @@
   (test-equality factory)
   (test-release factory)
   (test-vctr-op factory)
-  (test-ge-op factory))
+  (test-ge-op factory)
+  (test-vctr-contiguous factory)
+  (test-ge-contiguous factory)
+  (test-uplo-contiguous factory tr))
 
 (defn test-both-factories [factory0 factory1]
   (test-vctr-transfer factory0 factory1)
   (test-ge-transfer factory0 factory1)
   (test-tr-transfer factory0 factory1))
 
 (defn test-host [factory]
+  (test-uplo-contiguous factory sy)
   (test-vctr-ifn factory)
   (test-vctr-functor factory)
   (test-vctr-fold factory)