Make a distinction between forward and backward mmul #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your original version computes `M = A(B(C(D(EF))))`. This also adds `M = ((((AB)C)D)E)F`. Depending on the actual matrix sizes one is a lot faster than the other.
|
Thank you very much, Paul. I'll include this in the next round. I'll have to decline the PR since it slightly breaks the rest of the code, but I'll make sure I'll include it manually and it will be there in the next commit. |
|
I'm glad that an explanation was found. I hope Dragan updates the post. But that does not undermine his larger point - that his library is easier to use, and does the right thing under the hood. |
|
A response to this: https://dragan.rocks/articles/18/Neanderthal-vs-ND4J-vol3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your original version computes
M = A(B(C(D(EF)))). This also addsM = ((((AB)C)D)E)F. Depending on the actual matrix sizes one is a lot faster than the other.