New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a distinction between forward and backward mmul #47

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@treo

treo commented Jun 29, 2018

Your original version computes M = A(B(C(D(EF)))). This also adds M = ((((AB)C)D)E)F. Depending on the actual matrix sizes one is a lot faster than the other.

Make a distinction between forward and backward mmul
Your original version computes `M = A(B(C(D(EF))))`. This also adds `M = ((((AB)C)D)E)F`. Depending on the actual matrix sizes one is a lot faster than the other.
@blueberry

This comment has been minimized.

Member

blueberry commented Jun 29, 2018

Thank you very much, Paul. I'll include this in the next round. I'll have to decline the PR since it slightly breaks the rest of the code, but I'll make sure I'll include it manually and it will be there in the next commit.

@blueberry blueberry closed this Jun 29, 2018

@Biserkov

This comment has been minimized.

Biserkov commented Jun 29, 2018

I'm glad that an explanation was found. I hope Dragan updates the post. But that does not undermine his larger point - that his library is easier to use, and does the right thing under the hood.

@blueberry

This comment has been minimized.

Member

blueberry commented Jun 29, 2018

A response to this: https://dragan.rocks/articles/18/Neanderthal-vs-ND4J-vol3
Also, this change was added in the last commit: e09bede

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment