Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace some constants with ones from pint #253

Merged
merged 2 commits into from Jul 16, 2022

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Jul 15, 2022

fix #251

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 15, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 5.15%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 54.00 ⭐ 50.00 ⭐ -4.00 👍
Working memory 7.20 🙂 5.47 ⭐ -1.73 👍
Quality 77.27% 82.42% 5.15% 👍
Other metrics Before After Change
Lines 69 70 1
Changed files Quality Before Quality After Quality Change
particula/init.py 99.67% ⭐ 99.67% ⭐ 0.00%
particula/constants.py 73.82% 🙂 79.77% ⭐ 5.95% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ngam ngam marked this pull request as ready for review July 15, 2022 22:11
@ngam ngam merged commit db2e77c into uncscode:main Jul 16, 2022
@ngam ngam deleted the 251-use-scipyconstants branch July 16, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use scipy.constants
1 participant