Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword argument harmony #309

Merged
merged 7 commits into from Oct 12, 2022
Merged

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Oct 12, 2022

fix #308

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 12, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.86%.

Quality metrics Before After Change
Complexity 1.56 ⭐ 1.56 ⭐ 0.00
Method Length 44.25 ⭐ 45.75 ⭐ 1.50 👎
Working memory 7.00 🙂 8.00 🙂 1.00 👎
Quality 80.42% 77.56% -2.86% 👎
Other metrics Before After Change
Lines 91 91 0
Changed files Quality Before Quality After Quality Change
particula/util/aerodynamic_mobility.py 79.21% ⭐ 75.93% ⭐ -3.28% 👎
particula/util/slip_correction.py 81.94% ⭐ 79.60% ⭐ -2.34% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ngam ngam mentioned this pull request Oct 12, 2022
@ngam ngam requested a review from Gorkowski October 12, 2022 03:20
@ngam ngam merged commit 2f27a5c into uncscode:main Oct 12, 2022
@ngam ngam deleted the 308-keyword-argument-harmony branch October 12, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyword argument harmony
1 participant