Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kwargs to solver #312

Merged
merged 5 commits into from Oct 17, 2022
Merged

add kwargs to solver #312

merged 5 commits into from Oct 17, 2022

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Oct 17, 2022

@Gorkowski use do_coag, do_cond, do_nucl for now. We can fix this and do it more properly later. Releasing soon.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 17, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 7.21%.

Quality metrics Before After Change
Complexity 0.42 ⭐ 0.53 ⭐ 0.11 👎
Method Length 27.60 ⭐ 35.40 ⭐ 7.80 👎
Working memory 3.83 ⭐ 5.67 ⭐ 1.84 👎
Quality 93.38% 86.17% -7.21% 👎
Other metrics Before After Change
Lines 59 69 10
Changed files Quality Before Quality After Quality Change
particula/init.py 98.83% ⭐ 98.83% ⭐ 0.00%
particula/dynamics.py 92.29% ⭐ 84.22% ⭐ -8.07% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ngam ngam merged commit 285d076 into uncscode:main Oct 17, 2022
@ngam ngam deleted the 311-solverkw branch October 17, 2022 16:16
@Gorkowski
Copy link
Collaborator

Yeah that's a good plan, I'm going to think of some more changes that would be good after work with this for class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants