Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding more forces #419

Merged
merged 18 commits into from
Dec 16, 2023
Merged

adding more forces #419

merged 18 commits into from
Dec 16, 2023

Conversation

Gorkowski
Copy link
Collaborator

@Gorkowski Gorkowski commented Dec 10, 2023 •
edited
Loading

  • friction factor
  • drag
  • initial Brownian velocity
  • tests
  • example of realistic initial conditions

@Gorkowski Gorkowski added the .Lagrangian Lagrangian Box model code label Dec 10, 2023
@Gorkowski Gorkowski self-assigned this Dec 10, 2023
@Gorkowski Gorkowski marked this pull request as draft December 10, 2023 17:36
@sourcery-ai sourcery-ai bot mentioned this pull request Dec 10, 2023
Merged
@sourcery-ai
'Refactored by Sourcery' (#420)
ec43087 
Co-authored-by: Sourcery AI <>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://uncscode.github.io/particula/pr-preview/pr-419/
on branch gh-pages at 2023-12-16 17:43 UTC

@Gorkowski Gorkowski added this to the v0.1.0 milestone Dec 16, 2023
@ngmahfouz ngmahfouz marked this pull request as ready for review December 16, 2023 17:44
ngmahfouz
ngmahfouz approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@ngmahfouz ngmahfouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can improve the handling of these wrappers at some point, either here or elsewhere, but this is good to go!

@Gorkowski Gorkowski added this pull request to the merge queue Dec 16, 2023
Merged via the queue into main with commit f016645 Dec 16, 2023
9 checks passed
@Gorkowski Gorkowski deleted the Gorkowski/issue414 branch December 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngmahfouz ngmahfouz ngmahfouz approved these changes

Assignees

@Gorkowski Gorkowski

Labels
.Lagrangian Lagrangian Box model code
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gorkowski @ngmahfouz