Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Wall loss fitting prelim #427

Merged
merged 14 commits into from Jan 16, 2024
Merged

Adding Wall loss fitting prelim #427

merged 14 commits into from Jan 16, 2024

Conversation

Gorkowski
Copy link
Collaborator

@Gorkowski Gorkowski commented Jan 8, 2024

Adding Wall loss fitting via brute force, on a single experiment example.

  • Manual comparison
  • Auto minimization
  • MAE fit

@Gorkowski Gorkowski marked this pull request as draft January 8, 2024 18:24
Copy link

github-actions bot commented Jan 8, 2024

PR Preview Action v1.4.6
🚀 Deployed preview to https://uncscode.github.io/particula/pr-preview/pr-427/
on branch gh-pages at 2024-01-16 03:06 UTC

@ngmahfouz
Copy link
Collaborator

@Gorkowski I rebased here (including #422 and #423) and did a minor fix 34d18f8

@Gorkowski
Copy link
Collaborator Author

@ngmahfouz

I decided to just show a single time window fit for now, so that my student can start using this. If the functions in the notebook get more used then maybe we pull it in to the code base, but I'm fine with leave them in the example for now.

@Gorkowski Gorkowski marked this pull request as ready for review January 16, 2024 02:57
@Gorkowski Gorkowski added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit ced1125 Jan 16, 2024
9 checks passed
@Gorkowski Gorkowski deleted the Gorkowski/issue426 branch January 16, 2024 04:57
@ngmahfouz ngmahfouz changed the title Gorkowski/issue426 Adding Wall loss fitting prelim Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants