Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated dependencies #456

Closed
wants to merge 23 commits into from
Closed

Conversation

NovaAtWarren
Copy link

Removed the outdated "request" package, and installed axios, including converting any existing usages that I could find. All tests passed except:

  • Pages should resemble the reference: Bootstrap
  • Pages should resemble the reference: Selectors

These seemed to be because chromium wouldn't install when running yarn install.

@NovaAtWarren
Copy link
Author

It seems the CI is failing for OS compatibility reasons, instead of code, reasons, but if I'm wrong please tell me what I did that messed it up. Because I don't know.

@NovaAtWarren
Copy link
Author

Now also updates to version of coveralls without deprecated depenencies

@NovaAtWarren NovaAtWarren changed the title Converted from request to axios Remove deprecated sub-dependencies May 26, 2021
@NovaAtWarren NovaAtWarren changed the title Remove deprecated sub-dependencies Replace deprecated dependencies May 26, 2021
@NovaAtWarren
Copy link
Author

I would very much like this PR to be tested by someone on MacOS to assure my changes to fsevents usage doesn't break anything, and it's a MacOS only package.

@aminya aminya mentioned this pull request Jun 29, 2021
axios
is-html
mocha
@tomap
Copy link

tomap commented Sep 15, 2021

I believe you need to update node min version to node 12 (due to jsdom)

@NovaAtWarren
Copy link
Author

I believe you need to update node min version to node 12 (due to jsdom)

Thank you very much, I'd completely missed that.

Because that's the min version supported for JSDOM.
@NovaAtWarren
Copy link
Author

Being honest, I should probably close this as it's pretty clear it's not going to merge at this point, and the branch I made it from has just become a fork.

@tomap
Copy link

tomap commented Sep 16, 2021

I was thinking of using your fork to replace uncss. Seems much better

@NovaAtWarren
Copy link
Author

Seems much better

Just to clarify, I myself don't really see it as much better. It's barely had any changes from the master branch of this repo.
The difference is that it's still improving, where this one stagnated.
If it's useful though, and it does keep improving...

Well we'll see c:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants