fix(core): allow create nullable select value

fix #90
undb-xyz · Jan 1, 2023 · cf43602 · cf43602
1 parent e7c2896
commit cf43602
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/packages/core/field/select-field-value.ts b/packages/core/field/select-field-value.ts
@@ -4,7 +4,7 @@ import type { FieldValue } from './field.type'
 import type { ISelectFieldValue } from './select-field.type'
 
 export class SelectFieldValue extends ValueObject<ISelectFieldValue> {
-  constructor(value: string) {
+  constructor(value: ISelectFieldValue) {
     super({ value })
   }
 
@@ -16,7 +16,7 @@ export class SelectFieldValue extends ValueObject<ISelectFieldValue> {
     return new this(o.id.value)
   }
 
-  get id(): string {
+  get id(): ISelectFieldValue {
     return this.props.value
   }
 }
diff --git a/packages/core/field/select-field.ts b/packages/core/field/select-field.ts
@@ -50,6 +50,10 @@ export class SelectField extends BaseField<ISelectField> {
   }
 
   createValue(value: ICreateSelectFieldValue): SelectFieldValue {
+    if (value === null) {
+      return new SelectFieldValue(null)
+    }
+
     const option = this.options.getById(value).unwrap()
 
     return SelectFieldValue.fromOption(option)

diff --git a/packages/core/field/select-field.type.ts b/packages/core/field/select-field.type.ts
@@ -22,10 +22,10 @@ export const selectFieldQuerySchema = baseFieldQuerySchema.merge(selectTypeObjec
   }),
 )
 
-export const selectFieldValue = optionIdSchema
+export const selectFieldValue = optionIdSchema.nullable()
 export type ISelectFieldValue = z.infer<typeof selectFieldValue>
 
-export const createSelectFieldValue = optionIdSchema
+export const createSelectFieldValue = optionIdSchema.nullable()
 export type ICreateSelectFieldValue = z.infer<typeof createSelectFieldValue>
 
 export const createSelectFieldValue_internal = z