promote_type stack overflow

[ArrogantGao]

In

@inline function get_size_dict(ixs, xs, size_info=nothing)
    LT = promote_type(eltype.(ixs)...)
    return get_size_dict!(ixs, xs, size_info===nothing ? Dict{LT,Int}() : size_info)
end

the function promote_type is directly used and I found when the eltype.(ixs) is large (greater that 10000 for example), it causes stack overflow.

[ArrogantGao]

A possible solution

julia> function promote_type_array(T::Vector{DataType})
           LT = T[1]
           for i in 1:length(T)
               LT = promote_type(LT, T[i])
           end
           return LT
       end
promote_type_array (generic function with 1 method)

julia> type_array = [Int32 for i in 1:100000];

julia> promote_type_array(type_array)
Int32

[GiggleLiu]

A possible solution

julia> function promote_type_array(T::Vector{DataType})
           LT = T[1]
           for i in 1:length(T)
               LT = promote_type(LT, T[i])
           end
           return LT
       end
promote_type_array (generic function with 1 method)

julia> type_array = [Int32 for i in 1:100000];

julia> promote_type_array(type_array)
Int32

Yeah, that is true. Could you please help implement this change by submitting a PR?
Also, have you tried the reduce function? It could be an easier solution.

[ArrogantGao]

After using the reduce function the code seems much better

julia> type_array = [Int32 for i in 1:10000];

julia> @btime reduce($promote_type, $type_array)
  663.625 μs (0 allocations: 0 bytes)
Int32

I will submit a PR for that.