Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote_type stack overflow fix #161

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

ArrogantGao
Copy link
Contributor

Fix for issue #160.
The fixed function is given by

@inline function get_size_dict(ixs, xs, size_info=nothing)
    LT = reduce(promote_type, eltype.(ixs))
    return get_size_dict!(ixs, xs, size_info===nothing ? Dict{LT,Int}() : size_info)
end

@ArrogantGao
Copy link
Contributor Author

All tests passed after the change

Test Summary: | Pass  Total     Time
OMEinsum.jl   |  600    600  1m28.1s
     Testing OMEinsum tests passed 

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96582cc) 88.82% compared to head (716e813) 88.82%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files          12       12           
  Lines         975      975           
=======================================
  Hits          866      866           
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/interfaces.jl Outdated Show resolved Hide resolved
@GiggleLiu GiggleLiu merged commit 01a6bfa into under-Peter:master Jan 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants