[STAT] Added ranges to weight values #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, that makes sense to define the |
also turn soften into format 3 to see if it works in Adobe software then (it does)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fonts now include range definitions for the weight and optical size values in the stat table. The weight implementation is in tune with what other fonts are doing. Having something similar for the optical size would also make a lot of sense. So as a “discussion starter” I added range values there too. A value like
9pt[36] Black S100maybe also questions the current Google Fonts Spec when it comes to naming a optical size axis values. Feel free to investigate the current STAT table with Samsa.The missing 0 value for the wonk axis is due to the current limitations within statmake where you can only add values that are also present in the fvar (named instances). Hoping @madig can find some time for an update soon. ;-)
The fonts are installable without any unwanted duplicates on macOS Catalina and Windows 10, and works with some minor restrictions in InDesign, Illustratur, and Sketch.
CC: @davelab6 @m4rc1e