fix: Improve some internal return signatures and introduce testify #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
========================================
- Coverage 6.74% 6.60% -0.14%
========================================
Files 9 9
Lines 341 348 +7
========================================
Hits 23 23
- Misses 318 325 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks like this technically decreases code coverage 😅 I'm going to merge anyhow, and we will have an initiative to improve test coverage separately. |
Yup! I'm actually working on that right now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Switching away from my Pythonic roots to make our return signatures more Go-like. Go-onic? Go-ish? I dunno. Idiomatic.
This also introduces https://github.com/stretchr/testify for better testing assertions.