-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: JavaScript error 0.12.1 on desktop builds (macOS, Linux and Windows) #233
Comments
Thanks for the quick feedback and I'm sorry for the inconvenience and breaking the build. I've confirmed the issue you reported. It affects not just macOS, but also Windows and Linux. The root cause can be traced back to commit a14929a in 0.12.1 due to electron/electron#21457. I'm actively working on a fix and will roll out a patch release as soon as it's ready. Considerations & Workarounds
About portable releaseThe error you're seeing is part of a broader modernization effort in our tooling. We're making progress (which you can track at #230). After this update, enabling a Windows portable version will be easy with single line of code. I've attempted to integrate the portable feature using the current tools, but encountered challenges, especially as the dependencies used for desktop builds are now unmaintained. About the color |
I did a manual fix for now. If you re-install using the releases page it would work, and auto-updates would work for those who'll update after this issue happened, if anyone else got this error, please re-install the latest version using the releases page. I'm working on a real fix that will be released in next patch version a long with other improvements. |
I've confirmed the pink/purple image in the dmg, comes from the Electron Builder, which builds your dmg. |
- Add automation script for building, packaging, installing, executing and verifying Electron distrubtions across macOS, Ubuntu and Windows. - Add GitHub workflow to run the script to test distributions using the script. - Update README with new workflow status badge. - Add application initialization log to desktop applications to be able to test against crashes before application initialization.
As part of transition to Vue 3.0 and Vite (#230), this commit facilitates the shift towards building rest of the application using Vite. By doing so, it eliminates reliance on outdated Electron building system that offered limited control, blocking desktop builds (#233). Changes include: - Introduce Vite with Vue 2.0 plugin for test execution. - Remove `mocha`, `chai` and other related dependencies. - Adjust test to Vitest syntax. - Revise and update `tests.md` to document the changes. - Add `@modyfi/vite-plugin-yaml` plugin to be able to use yaml file depended logic on test files, replacing previous webpack behavior. - Fix failing tests that are revealed by Vitest due to unhandled errors and lack of assertments. - Remove the test that depends on Vue CLI populating `process.env`.
As part of transition to Vue 3.0 and Vite (#230), this commit facilitates the shift towards building rest of the application using Vite. By doing so, it eliminates reliance on outdated Electron building system that offered limited control, blocking desktop builds (#233). Changes include: - Introduce Vite with Vue 2.0 plugin for test execution. - Remove `mocha`, `chai` and other related dependencies. - Adjust test to Vitest syntax. - Revise and update `tests.md` to document the changes. - Add `@modyfi/vite-plugin-yaml` plugin to be able to use yaml file depended logic on test files, replacing previous webpack behavior. - Fix failing tests that are revealed by Vitest due to unhandled errors and lack of assertments. - Remove the test that depends on Vue CLI populating `process.env`.
As part of transition to Vue 3.0 and Vite (#230), this commit facilitates the shift towards building rest of the application using Vite. By doing so, it eliminates reliance on outdated Electron building system that offered limited control, blocking desktop builds (#233). Changes include: - Introduce Vite with Vue 2.0 plugin for test execution. - Remove `mocha`, `chai` and other related dependencies. - Adjust test to Vitest syntax. - Revise and update `tests.md` to document the changes. - Add `@modyfi/vite-plugin-yaml` plugin to be able to use yaml file depended logic on test files, replacing previous webpack behavior. - Fix failing tests that are revealed by Vitest due to unhandled errors and lack of assertments. - Remove the test that depends on Vue CLI populating `process.env`. - Use `jsdom` for unit test environment, adding it to dependency to `package.json` as project now depends on it and it was not specified even though `package-lock.json` included it.
- Switch from deprecated Vue CLI plugin to `electron-vite` (see nklayman/vue-cli-plugin-electron-builder#1982) - Update main/preload scripts to use `index.cjs` filenames to support `"type": "module"`, resolving crash issue (#233). This crash was related to Electron not supporting ESM (see electron/asar#249, electron/electron#21457). - This commit completes migration to Vite from Vue CLI (#230). Structure changes: - Introduce separate folders for Electron's main and preload processes. - Move TypeHelpers to `src/` to mark tit as accessible by the rest of the code. Config changes: - Make `vite.config.ts` reusable by Electron configuration. - On electron-builder, use `--publish` flag instead of `-p` for clarity. Tests: - Add log for preload script loading verification. - Implement runtime environment sanity checks. - Enhance logging in `check-desktop-runtime-errors`.
Hi, the crash is now resolved with 0.12.2. It required a few thousands of lines code added. But now these errors can be detected early and all packages can be controlled by single file so I will add the portable version in next patch for you :) Thanks for the report and you know I appreciate you having in the community. |
JavaScript error 0.12.1 macOS
![Privacy Sexy JavaScript error](https://private-user-images.githubusercontent.com/35133409/261670480-09a17c29-0aae-401c-af4b-d225324a7643.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxNzY0OTAsIm5iZiI6MTcyMjE3NjE5MCwicGF0aCI6Ii8zNTEzMzQwOS8yNjE2NzA0ODAtMDlhMTdjMjktMGFhZS00MDFjLWFmNGItZDIyNTMyNGE3NjQzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE0MTYzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjOTI1ZjRmYmU0N2Q0NDE0NzYzMzMzZTZmMjViNzVjOTkxMmVkMDI5OGYxZTQ5NTcyMWY1NDE4ZjI5OTFiZDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rkx1vXpw-vghue3KNVhigpeWXe8gmcU0mrCsPlfMpwQ)
![Launchpad](https://private-user-images.githubusercontent.com/35133409/261671846-0105d0fc-ae89-4523-ad8a-9591bc83e192.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxNzY0OTAsIm5iZiI6MTcyMjE3NjE5MCwicGF0aCI6Ii8zNTEzMzQwOS8yNjE2NzE4NDYtMDEwNWQwZmMtYWU4OS00NTIzLWFkOGEtOTU5MWJjODNlMTkyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE0MTYzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJlMmMyNGUwZDg0MjIyODgyOGYyZTExMjViODgwODJjODk0ZWU3MDE4ODUxNDRjZTY3ZGQ1MDJiMmM2YTdmMDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TvsObXhx3iamGVaLUs2EzNs25-2q6EVosDNQ0gO4PxY)
![privacy sexy Purple Pink](https://private-user-images.githubusercontent.com/35133409/261672307-bdd4d949-608b-44bc-b987-683ea934f44a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxNzY0OTAsIm5iZiI6MTcyMjE3NjE5MCwicGF0aCI6Ii8zNTEzMzQwOS8yNjE2NzIzMDctYmRkNGQ5NDktNjA4Yi00NGJjLWI5ODctNjgzZWE5MzRmNDRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI4VDE0MTYzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkNDA3MmZiZWIxNmI1MmIyOTNmZDIzMzU5ZTgxMzJhYmZiYmQ2MTk0M2I3Njc3ZTI5YWY5MmQ4NGVhMDg3ZDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.s-1dTAypqD42xcqq2Yfvh_mOhBuKvQEY-euxZjjiY2k)
App opens, functions unable to be seen.
Display:
macOS 10.15.7
It would be helpful to see in Launchpad, if if you changed the App's Blue color Hex 3A65AB RGB 58 101 171 to another shade of blue or a different color, or use the Official privacy.sexy purple pink dmg coloring.
And like I mentioned to you before, if you make the Windows Version, Portable, I will use & try.
The text was updated successfully, but these errors were encountered: