Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Mode: App is the Backend URL Address #77

Conversation

wjiuhe
Copy link
Member

@wjiuhe wjiuhe commented May 25, 2022

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Operating System:

Platform:

Target Platform:

Pinference Version:

@wjiuhe wjiuhe linked an issue May 25, 2022 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #77 (9ae3142) into main (283a3ad) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #77   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         1138      1150   +12     
=========================================
+ Hits          1138      1150   +12     
Impacted Files Coverage Δ
pinferencia/main.py 100.00% <100.00%> (ø)
pinferencia/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283a3ad...9ae3142. Read the comment docs.

@wjiuhe wjiuhe merged commit d2d731c into main May 25, 2022
@wjiuhe wjiuhe deleted the 62-in-frontend-mode-app-should-not-be-a-compulsory-argument-of-pinfer branch May 25, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In frontend mode, APP should not be a compulsory argument of pinfer
1 participant