Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taxonomy Class Trips Fatal Error #10

Closed
alexstandiford opened this issue Dec 4, 2020 · 1 comment · Fixed by #11
Closed

Taxonomy Class Trips Fatal Error #10

alexstandiford opened this issue Dec 4, 2020 · 1 comment · Fixed by #11

Comments

@alexstandiford
Copy link
Collaborator

This is because the $name param is set to protected when it must be public. It should probably be removed from this class in general since this class extends Feature_Extension and inherits this variable anyway.
alexstandiford added a commit that referenced this issue Dec 5, 2020
@alexstandiford
Removes un-necessary name declaration. #10
2efa1ac
@alexstandiford alexstandiford linked a pull request Dec 5, 2020 that will close this issue
Removes un-necessary name declaration. #10 #11
Merged
alexstandiford added a commit that referenced this issue Dec 5, 2020
@alexstandiford
Removes un-necessary name declaration. #10 (#11)
4f8bfca 
Resolves 10
alexstandiford added a commit that referenced this issue Dec 5, 2020
@alexstandiford @szepeviktor
Release/1.0.1 (#13)
f4f3d0a 
* Removes un-necessary name declaration. #10 (#11)

Resolves 10

* Update Admin_Page.php (#6)

* Update Admin_Menu.php (#5)

* Update Rest_Endpoint.php (#2)

Co-authored-by: Viktor Szépe <viktor@szepe.net>
@alexstandiford
Copy link
Collaborator Author

Resolved in #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes un-necessary name declaration. #10 Underpin-WP/underpin
1 participant
@alexstandiford