Skip to content

Commit

Permalink
Release/1.0.1 (#13)
Browse files Browse the repository at this point in the history
* Removes un-necessary name declaration. #10 (#11)

Resolves 10

* Update Admin_Page.php (#6)

* Update Admin_Menu.php (#5)

* Update Rest_Endpoint.php (#2)

Co-authored-by: Viktor Szépe <viktor@szepe.net>
  • Loading branch information
alexstandiford and szepeviktor committed Dec 5, 2020
1 parent 3d315ca commit f4f3d0a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 19 deletions.
4 changes: 1 addition & 3 deletions lib/abstracts/Admin_Menu.php
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,6 @@ public function validate() {
* Adds the admin bar.
*
* @since 1.0.0
*
* @param WP_Admin_Bar $admin_bar The admin bar object.
*/
public function add_admin_menu() {

Expand Down Expand Up @@ -177,4 +175,4 @@ public function get_url( $query = [] ) {

return $url;
}
}
}
4 changes: 1 addition & 3 deletions lib/abstracts/Admin_Page.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ abstract class Admin_Page extends Admin_Sub_Menu {
* Admin_Page constructor.
*
* @since 1.0.0
*
* @param array $args List of arguments used to create this menu page.
*/
public function __construct() {
parent::__construct();
Expand Down Expand Up @@ -305,4 +303,4 @@ public function __get( $key ) {
}
}

}
}
10 changes: 5 additions & 5 deletions lib/abstracts/Rest_Endpoint.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Underpin\Abstracts;

use Underpin\Traits\Feature_Extension;
use WP_Rest_Request;
use WP_REST_Request;
use function Underpin\underpin;

if ( ! defined( 'ABSPATH' ) ) {
Expand Down Expand Up @@ -42,10 +42,10 @@ abstract class Rest_Endpoint {
*
* @since 1.0.0
*
* @param WP_Rest_Request $request The request object.
* @param WP_REST_Request $request The request object.
* @return mixed the REST endpoint response.
*/
abstract function endpoint( WP_Rest_Request $request );
abstract function endpoint( WP_REST_Request $request );

/**
* Has permission callback.
Expand All @@ -55,7 +55,7 @@ abstract function endpoint( WP_Rest_Request $request );
* @param WP_Rest_Request $request The request object.
* @return mixed the REST endpoint response.
*/
abstract function has_permission( WP_Rest_Request $request );
abstract function has_permission( WP_REST_Request $request );

/**
* Rest_Endpoint constructor.
Expand Down Expand Up @@ -109,4 +109,4 @@ public function __get( $key ) {
}
}

}
}
9 changes: 1 addition & 8 deletions lib/abstracts/Taxonomy.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,7 @@
*/
abstract class Taxonomy {
use Feature_Extension;
/**
* The taxonomy name.
*
* @since 1.0.0
*
* @var string The post type "$type" argument.
*/
protected $name = '';


/**
* The post type args.
Expand Down

0 comments on commit f4f3d0a

Please sign in to comment.