Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Theme json Support #1645

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

WIP: Theme json Support #1645

wants to merge 1 commit into from

Conversation

bacoords
Copy link
Member

@bacoords bacoords commented Mar 3, 2022

This is a paired PR along with understrap/postcss-understrap-palette-generator#2
This is a Work In Progress PR.

Description

The idea here is to support theme.json instead of our own custom JSON object that passes bootstrap colors to the gutenberg editor. We're simultaneously updating the postcss plugin along with the theme to test this out.

Motivation and Context

Theme json is taking over for techniques like add_theme_support( 'editor-color-palette', $color_palette ); so we want to support them with Understrap

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to change) maybe

Checklist:

  • [x ] I pulled my branch from develop.
  • [ x] I am submitting my pull request to develop.
  • [ x] I have resolved any conflicts merging this pull request would create.
  • [x ] I have checked that there aren't other open Pull Requests for the same update/change.
  • [x ] My code follows the code style of this project.
  • [x ] I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • (Optional) My change requires a change to the documentation.
  • (Optional) I have updated the documentation accordingly.
  • (Optional) My change requires a change to the translations.
  • (Optional) I have updated the translations accordingly.
  • composer cs:check has passed locally.
  • composer lint:php has passed locally.
  • [x ] I have read the CONTRIBUTING document.

Related Issues or Roadmap requests

Related to understrap/postcss-understrap-palette-generator#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Test Support for theme.json
1 participant