Support Script Debug #1458
Merged
Support Script Debug #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Understrap is already including the unminified version of assets. These can be useful when debugging locally, or if minification is happening elsewhere in the stack. WordPress uses the SCRIPT_DEBUG constant to tell core not to minify assets. This PR brings that logic to understrap
0dp
previously approved these changes
Oct 7, 2021
bacoords
previously approved these changes
Oct 7, 2021
bacoords
dismissed stale reviews from 0dp and themself
The base branch was changed.
bacoords
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Understrap is already including the unminified version of assets.
These can be useful when debugging locally, or if minification is happening elsewhere in the stack.
WordPress uses the SCRIPT_DEBUG constant to tell core not to minify assets.
This PR brings that logic to understrap
Motivation and Context
Fixes #1456 which has more context on why this is needed.
Types of changes
Checklist:
develop.develop.composer cs:checkhas passed locally.composer lint:phphas passed locally.I pulled from Feature Bootstrap 5, but looks like I should have pulled from develop my thought was this could be released along side the Bootstrap 5 launch and it made sense to do the work now instead of doing it again when that release happens.