Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "Go to shop" translate issue #1472

Merged
merged 2 commits into from Oct 29, 2021
Merged

Fixes "Go to shop" translate issue #1472

merged 2 commits into from Oct 29, 2021

Conversation

Piirka
Copy link
Contributor

@Piirka Piirka commented Oct 19, 2021

Description

Motivation and Context

Woocommerce translations does not have translation string for "Go to the shop". Use "Go to shop" instead.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • (Optional) My change requires a change to the documentation.
  • (Optional) I have updated the documentation accordingly.
  • (Optional) My change requires a change to the translations.
  • (Optional) I have updated the translations accordingly.
  • composer cs:check has passed locally.
  • composer lint:php has passed locally.
  • I have read the CONTRIBUTING document.

Related Issues or Roadmap requests

Further comments

@bacoords
Copy link
Member

Thanks! I've pulled the latest template from Woocommerce. It actually uses the phrase "Browse products"- I believe we had some older templates hanging around for some reason

@bacoords bacoords merged commit 9f13587 into understrap:develop Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants