Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor understrap_entry_footer() #1831

Merged
merged 6 commits into from Aug 5, 2022

Conversation

IanDelMar
Copy link
Contributor

@IanDelMar IanDelMar commented Jul 24, 2022

Description

This PR refactors understrap_entry_footer() in order to

  • reduce complexity
  • increase readability
  • make it easier for child themes to not display components of the entry footer by e.g. defining function understrap_tags_list() { return; }

Motivation and Context

See above.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

None of these.

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • (Optional) My change requires a change to the documentation.
  • (Optional) I have updated the documentation accordingly.
  • (Optional) My change requires a change to the translations.
  • (Optional) I have updated the translations accordingly.
  • composer cs:check has passed locally.
  • composer lint:php has passed locally.
  • I have read the CONTRIBUTING document.

Related Issues or Roadmap requests

Further comments

PHPStan errors addressed in #1830

@IanDelMar
Copy link
Contributor Author

@bacoords ready for review

@bacoords bacoords merged commit e2793cc into understrap:develop Aug 5, 2022
@IanDelMar IanDelMar deleted the entry-footer branch August 5, 2022 15:47
@IanDelMar IanDelMar mentioned this pull request Aug 13, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants