Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notices #1832

Merged
merged 1 commit into from Jul 25, 2022
Merged

Add deprecation notices #1832

merged 1 commit into from Jul 25, 2022

Conversation

IanDelMar
Copy link
Contributor

Description

This PR adds deprecation notices to function residing in inc/deprecated.php.

Motivation and Context

Prepare users to removal of function in some future version.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • (Optional) My change requires a change to the documentation.
  • (Optional) I have updated the documentation accordingly.
  • (Optional) My change requires a change to the translations.
  • (Optional) I have updated the translations accordingly.
  • composer cs:check has passed locally.
  • composer lint:php has passed locally.
  • I have read the CONTRIBUTING document.

Related Issues or Roadmap requests

Further comments

@IanDelMar
Copy link
Contributor Author

@bacoords should be safe to merge

Copy link
Member

@bacoords bacoords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting reading through the old discussions on the .tag class in Bootstrap.

@bacoords bacoords merged commit 65be087 into understrap:develop Jul 25, 2022
@IanDelMar IanDelMar deleted the deprecate branch July 25, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants